On 2011-05-05 10:08, Avi Kivity wrote: > On 05/04/2011 10:43 PM, Jan Kiszka wrote: >> From: Jan Kiszka<jan.kiszka@xxxxxxxxxxx> >> >> Paravirtual MSRs are properly cleared on reset now, and blindly clearing >> the rest is questionable anyway (better address those one by one, >> re-initializing their backing CPU state fields). >> > > This can introduce a regression when new paravirtual MSRs are added. You mean MSRs already included or future ones? > So > we either need to port this, or query the reset state from the kernel > immediately after creating the vcpu and saving it. Can't completely follow what you mean. My general point remains: Every MSR requires individual care, not blind overwriting like qemu-kvm does. So the person contributing a new MSR, real or pv, has to tackle this aspect, and we need to review the code in this regard. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
