* Pekka Enberg <penberg@xxxxxxxxxx> wrote: > On Thu, May 5, 2011 at 10:02 AM, Ingo Molnar <mingo@xxxxxxx> wrote: > > > > * Asias He <asias.hejun@xxxxxxxxx> wrote: > > > >> With commit d7f0c07afeefa2d20739437306e4b8bb2853cf83 in master > >> (kvm tools: Fix virt_queue__set_used_elem) > >> > >> I see this: > >> > >> asias@hj:~/qemu-stuff/pekka.git/tools/kvm$ make > >> GEN include/common-cmds.h > >> ../../include/asm-generic/bitops/fls64.h:33:2: error: #error > >> BITS_PER_LONG not 32 or 64 > > > > The build fails here too, in a similar way, on a 32-bit Fedora 14 box. > > Curious. It works fine on my box. I think it's missing #include > <asm/bitsperlong.h>. I wonder why system.h isn't pulling that > itself... asm/system.h is one of the messier kernel headers, so i'm not surprised it has assymetric requirements on 64-bit and 32-bit systems. We could fix it (provide those dependencies), or we could pick tools/perf/perf.h's mb() definitions. That's much cruder than the nice kernel memory barriers though ... Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
