On Thu, Nov 25, 2010 at 10:17:53AM -0500, Avi Kivity wrote: > On 11/25/2010 03:13 PM, Roedel, Joerg wrote: > > On Thu, Nov 25, 2010 at 12:46:40PM +0100, Roedel, Joerg wrote: > > > We basically have two choices here: > > > > > > a) We expose svm internals into the emulator > > > b) We expose emulator internals into svm > > > > > > Both choices are not really good from a software-design point-of-view. > > > But I think option b) is the better one because it is easier to cope with > > > and thus less likely to break when changing the emulator code. > > > > What we could do probably is to define the interface between the > > emulator and the architecture code in a better way. This would take the > > burden of going into architecture code for emulator changes away. > > What about things like adding instructions and forgetting to add the > corresponding svm.c code? Cannot happen. Every instruction that can be intercepted with SVM is already handled in this patch-set. > Good idea. Needed for the decode bits thing as well. Especially needed to not kill the L1 guest when an L2 instruction emulation fails :) Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
