Re: [KVM-AUTOTEST][PATCH 2/2][virtio-console] Fix compatibility with python 2.4.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dne 23.11.2010 03:30, Amos Kong napsal(a):
----- "JiÅÃ Åupka"<jzupka@xxxxxxxxxx>  wrote:

---

After loading your this patch, virtio_console also could not work with older python.

Something are not fixed, such as:
   "return True if self.failed>  0 else False"
   "PASS"if result[0] else "FAIL"
   ...

I'm testing with 'Python 2.4.3'

Hi,

this fixes only the GUEST (virtio_guest.py) side of the virtio_console test. (tested with python 2.4.3 and 2.4.6)

It's possible to fix the host side too but distributions which supports only python 2.4 usually supports older versions of KVM without the '-device' option we use in the HOST side of the test for creating the devices. This change would only make the code less readable with minimal income.

Anyway if there's a real demand, we can fix the HOST side too.

Cheers,
LukÃÅ

      def close(self, file):
@@ -339,7 +341,7 @@ class VirtioGuest:
              if descriptor != None:

--
1.7.3.2
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux