On Mon, 2010-11-08 at 11:39 +0800, Anthony Liguori wrote: > On 11/07/2010 07:29 PM, Huang Ying wrote: > > On Sun, 2010-11-07 at 00:24 +0800, Avi Kivity wrote: > > > >> On 11/01/2010 03:22 PM, Anthony Liguori wrote: > >> > >>> On 11/01/2010 02:20 PM, Huang Ying wrote: > >>> > >>>> Yes. As general interface, it may not work so well, but as test > >>>> interface, it works quite well and useful. > >>>> > >>>> Do we have any mechanism to add a test only interface? > >>>> > >>> I'd like to see what Luiz/Markus think but definitely only a human > >>> monitor interface and probably prefix the command with a 'x-' prefix > >>> to indicate that it's not a supported interface. > >>> > >>> > >> Automated testing will want to use qmp. > >> > > Yes. The main usage of the interface is automated testing. > > > > That's precisely what the command should not be used for. > > You can't assume a gpa -> hva mapping is consistent in an external > application. If you want to implement an interface for testing, you > have to push more of the logic into QEMU to avoid the race. >From the code of cpu_physical_memory_map(), it seems that if the 'addr' is physical address in RAM, the mapping should be consistent at least for x86, doesn't it? Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html