On Mon, 2010-11-01 at 11:49 -0700, Anthony Liguori wrote: > On 11/01/2010 11:09 AM, Marcelo Tosatti wrote: > > On Tue, Oct 26, 2010 at 10:39:48AM +0800, Huang Ying wrote: > > > >> Author: Max Asbock<masbock@xxxxxxxxxxxxxxxxxx> > >> > >> Add command pfa2hva to translate guest physical address to host > >> virtual address. > >> > >> The pfa2hva command provides one step in a chain of translations from > >> guest virtual to guest physical to host virtual to host physical. Host > >> physical is then used to inject a machine check error. As a > >> consequence the HWPOISON code on the host and the MCE injection code > >> in qemu-kvm are exercised. > >> > >> v2: > >> > >> - Add QMP support > >> > > > > Looks good to me. Anthony? > > > > The translation is not stable so this is really a bad interface. > > It definitely shouldn't be a QMP command and I don't think it's > generally useful enough that it should be a monitor command. > > It's impossible to use correctly as a general interface. > > I gave this feedback when it was initially submitted. Yes. As general interface, it may not work so well, but as test interface, it works quite well and useful. Do we have any mechanism to add a test only interface? Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
