On Fri, 10 Jan 2025 16:29:44 -0800, Sean Christopherson wrote: > Fix a variety of flaws and false failures/passes in dirty_log_test, and > drop code/behavior that adds complexity while adding little-to-no benefit. > > Lots of details in the changelogs, and a partial list of complaints[1] in > Maxim's original thread[2]. > > [1] https://lore.kernel.org/all/Z1vR25ylN5m_DRSy@xxxxxxxxxx > [2] https://lore.kernel.org/all/20241211193706.469817-1-mlevitsk@xxxxxxxxxx > > [...] Applied to kvm-x86 selftests, thanks! [01/20] KVM: selftests: Support multiple write retires in dirty_log_test https://github.com/kvm-x86/linux/commit/fe49f8005257 [02/20] KVM: selftests: Sync dirty_log_test iteration to guest *before* resuming https://github.com/kvm-x86/linux/commit/67428ee7b746 [03/20] KVM: selftests: Drop signal/kick from dirty ring testcase https://github.com/kvm-x86/linux/commit/ff0efc77bc96 [04/20] KVM: selftests: Drop stale srandom() initialization from dirty_log_test https://github.com/kvm-x86/linux/commit/1230907864d7 [05/20] KVM: selftests: Precisely track number of dirty/clear pages for each iteration https://github.com/kvm-x86/linux/commit/af2d85d34d15 [06/20] KVM: selftests: Read per-page value into local var when verifying dirty_log_test https://github.com/kvm-x86/linux/commit/f2228aa08324 [07/20] KVM: selftests: Continuously reap dirty ring while vCPU is running https://github.com/kvm-x86/linux/commit/9b1feec83e1a [08/20] KVM: selftests: Limit dirty_log_test's s390x workaround to s390x https://github.com/kvm-x86/linux/commit/deb8b8400e31 [09/20] KVM: selftests: Honor "stop" request in dirty ring test https://github.com/kvm-x86/linux/commit/f3629c0ef167 [10/20] KVM: selftests: Keep dirty_log_test vCPU in guest until it needs to stop https://github.com/kvm-x86/linux/commit/0a818b3541af [11/20] KVM: selftests: Post to sem_vcpu_stop if and only if vcpu_stop is true https://github.com/kvm-x86/linux/commit/9a91f6542435 [12/20] KVM: selftests: Use continue to handle all "pass" scenarios in dirty_log_test https://github.com/kvm-x86/linux/commit/c616f36a1002 [13/20] KVM: selftests: Print (previous) last_page on dirty page value mismatch https://github.com/kvm-x86/linux/commit/24b9a2a61377 [14/20] KVM: selftests: Collect *all* dirty entries in each dirty_log_test iteration https://github.com/kvm-x86/linux/commit/d0bd72cb9160 [15/20] KVM: sefltests: Verify value of dirty_log_test last page isn't bogus https://github.com/kvm-x86/linux/commit/485e27ed208f [16/20] KVM: selftests: Ensure guest writes min number of pages in dirty_log_test https://github.com/kvm-x86/linux/commit/73eaa2aa14b7 [17/20] KVM: selftests: Tighten checks around prev iter's last dirty page in ring https://github.com/kvm-x86/linux/commit/2020d3b77a5a [18/20] KVM: selftests: Set per-iteration variables at the start of each iteration https://github.com/kvm-x86/linux/commit/2680dcfb34e2 [19/20] KVM: selftests: Fix an off-by-one in the number of dirty_log_test iterations https://github.com/kvm-x86/linux/commit/7f225650e099 [20/20] KVM: selftests: Allow running a single iteration of dirty_log_test https://github.com/kvm-x86/linux/commit/dae7d81e8d58 -- https://github.com/kvm-x86/linux/tree/next
