On Fri, 10 Jan 2025 16:50:40 -0800, Sean Christopherson wrote: > Fix a handful of bugs in the binary stats infrastructure, expand support > to vCPU-scoped stats, enumerate all KVM stats in selftests, and use the > enumerated stats to assert at compile-time that {vm,vcpu}_get_stat() is > getting a stat that actually exists. > > Most of the bugs are benign, and AFAICT, none actually cause problems in > the current code base. The worst of the bugs is lack of validation that > the requested stat actually exists, which is quite annoying if someone > fat fingers a stat name, tries to get a vCPU stat on a VM FD, etc. > > [...] Applied to kvm-x86 selftests (attempt #2). Like the previous attempt, I skipped the compile-time assertions. [1/9] KVM: selftests: Fix mostly theoretical leak of VM's binary stats FD https://github.com/kvm-x86/linux/commit/fd546aba1967 [2/9] KVM: selftests: Close VM's binary stats FD when releasing VM https://github.com/kvm-x86/linux/commit/f7f232a01f3d [3/9] KVM: selftests: Assert that __vm_get_stat() actually finds a stat https://github.com/kvm-x86/linux/commit/eead13d493af [4/9] KVM: selftests: Macrofy vm_get_stat() to auto-generate stat name string https://github.com/kvm-x86/linux/commit/b0c3f5df9291 [5/9] KVM: selftests: Add struct and helpers to wrap binary stats cache https://github.com/kvm-x86/linux/commit/e65faf71bd54 [6/9] KVM: selftests: Get VM's binary stats FD when opening VM https://github.com/kvm-x86/linux/commit/ea7179f99514 [7/9] KVM: selftests: Adjust number of files rlimit for all "standard" VMs https://github.com/kvm-x86/linux/commit/9b56532b8a59 [8/9] KVM: selftests: Add infrastructure for getting vCPU binary stats https://github.com/kvm-x86/linux/commit/16fc7cb406a5 [9/9] KVM: selftests: Add compile-time assertions to guard against stats typos (no commit info) -- https://github.com/kvm-x86/linux/tree/next