On Fri, 2025-01-10 at 16:29 -0800, Sean Christopherson wrote: > Fix a variety of flaws and false failures/passes in dirty_log_test, and > drop code/behavior that adds complexity while adding little-to-no benefit. > > Lots of details in the changelogs, and a partial list of complaints[1] in > Maxim's original thread[2]. > > [1] https://lore.kernel.org/all/Z1vR25ylN5m_DRSy@xxxxxxxxxx > [2] https://lore.kernel.org/all/20241211193706.469817-1-mlevitsk@xxxxxxxxxx > > v2: > - Collect reviews. [Maxim] > - Expand a few changelogs to be more explicit about the effects. [Maxim] > - Print the number of writes from each iteration. [Maxim] > - Fix goofs in the last patch (stale message and changelog). [Maxim] > > v1: https://lore.kernel.org/all/20241214010721.2356923-1-seanjc@xxxxxxxxxx > > Maxim Levitsky (2): > KVM: selftests: Support multiple write retires in dirty_log_test > KVM: selftests: Limit dirty_log_test's s390x workaround to s390x > > Sean Christopherson (18): > KVM: selftests: Sync dirty_log_test iteration to guest *before* > resuming > KVM: selftests: Drop signal/kick from dirty ring testcase > KVM: selftests: Drop stale srandom() initialization from > dirty_log_test > KVM: selftests: Precisely track number of dirty/clear pages for each > iteration > KVM: selftests: Read per-page value into local var when verifying > dirty_log_test > KVM: selftests: Continuously reap dirty ring while vCPU is running > KVM: selftests: Honor "stop" request in dirty ring test > KVM: selftests: Keep dirty_log_test vCPU in guest until it needs to > stop > KVM: selftests: Post to sem_vcpu_stop if and only if vcpu_stop is true > KVM: selftests: Use continue to handle all "pass" scenarios in > dirty_log_test > KVM: selftests: Print (previous) last_page on dirty page value > mismatch > KVM: selftests: Collect *all* dirty entries in each dirty_log_test > iteration > KVM: sefltests: Verify value of dirty_log_test last page isn't bogus > KVM: selftests: Ensure guest writes min number of pages in > dirty_log_test > KVM: selftests: Tighten checks around prev iter's last dirty page in > ring > KVM: selftests: Set per-iteration variables at the start of each > iteration > KVM: selftests: Fix an off-by-one in the number of dirty_log_test > iterations > KVM: selftests: Allow running a single iteration of dirty_log_test > > tools/testing/selftests/kvm/dirty_log_test.c | 521 +++++++++---------- > 1 file changed, 246 insertions(+), 275 deletions(-) > > > base-commit: 10485c4bc3caad3e93a6a4e99003e8ffffcd826a I don't think I have any major objections to this patch series. Best regards, Maxim Levitsky
