> From: Liu, Yi L <yi.l.liu@xxxxxxxxx> > Sent: Tuesday, November 5, 2024 1:24 PM > > On 2024/11/5 10:49, Baolu Lu wrote: > > On 11/4/24 21:18, Yi Liu wrote: > >> To handle domain replacement, the intel_iommu_set_dev_pasid() needs > to > >> keep the old configuration and the prepare for the new setup. This > requires > >> a bit refactoring to prepare for it. > > > > Above description is a bit hard to understand, are you saying > > > > ... the intel_iommu_set_dev_pasid() needs to roll back to the old > > configuration in the failure path, therefore refactor it to prepare for > > the subsequent patches ... > > This is the partial reason, but not the most related reason of this patch. > Say without this patch, the intel_iommu_set_dev_pasid() call avoid roll > back to the old configuration in the failure path as long as it calls the > pasid replace helpers. So I chose to describe like the above. Maybe another > choice is to name this patch as consolidate the dev_pasid_info adding and > removing to be a paired helpers. This can be used by other set_dev_pasid op > within intel iommu driver. > paired helpers is clearer.
