On 11/4/24 21:18, Yi Liu wrote:
To handle domain replacement, the intel_iommu_set_dev_pasid() needs to keep the old configuration and the prepare for the new setup. This requires a bit refactoring to prepare for it.
Above description is a bit hard to understand, are you saying ... the intel_iommu_set_dev_pasid() needs to roll back to the old configuration in the failure path, therefore refactor it to prepare for the subsequent patches ... ?
domain_add_dev_pasid() and domain_remove_dev_pasid() are added to add/remove the dev_pasid_info which represents the association of the pasid/device and domain. Till now, it's still not ready for replacement yet. Signed-off-by: Yi Liu<yi.l.liu@xxxxxxxxx> --- drivers/iommu/intel/iommu.c | 90 +++++++++++++++++++++++++------------ 1 file changed, 61 insertions(+), 29 deletions(-)
The change itself looks good to me, Reviewed-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
