On Tue, Oct 17, 2023 at 05:52:24AM +0000, Oliver Upton wrote: > On Mon, Oct 16, 2023 at 02:35:52PM -0700, Raghavendra Rao Ananta wrote: > > [...] > > > > What's the point of doing this in the first place? The implementation of > > > kvm_vcpu_read_pmcr() is populating PMCR_EL0.N using the VM-scoped value. > > > > > I guess originally the change replaced read_sysreg(pmcr_el0) with > > kvm_vcpu_read_pmcr(vcpu) to maintain consistency with others. > > But if you and Sebastian feel that it's an overkill and directly > > getting the value via vcpu->kvm->arch.pmcr_n is more readable, I'm > > happy to make the change. > > No, I'd rather you delete the line where PMCR_EL0.N altogether. ... where we set up ... > reset_pmcr() tries to initialize the field, but your > kvm_vcpu_read_pmcr() winds up replacing it with pmcr_n. -- Thanks, Oliver
