On Tue, Oct 10, 2023 at 09:56:00AM -0400, Michael S. Tsirkin wrote: > > However - the Intel GPU VFIO driver is such a bad experiance I don't > > want to encourage people to make VFIO drivers, or code that is only > > used by VFIO drivers, that are not under drivers/vfio review. > > So if Alex feels it makes sense to add some virtio functionality > to vfio and is happy to maintain or let you maintain the UAPI > then why would I say no? But we never expected devices to have > two drivers like this does, so just exposing device pointer > and saying "use regular virtio APIs for the rest" does not > cut it, the new APIs have to make sense > so virtio drivers can develop normally without fear of stepping > on the toes of this admin driver. Please work with Yishai to get something that make sense to you. He can post a v2 with the accumulated comments addressed so far and then go over what the API between the drivers is. Thanks, Jason