On Sun, Oct 01, 2023 at 11:28:26PM -0700, Christoph Hellwig wrote: > On Tue, Sep 26, 2023 at 07:41:44AM -0400, Michael S. Tsirkin wrote: > > > > Except, there's no reasonable way for virtio to know what is done with > > the device then. You are not using just 2 symbols at all, instead you > > are using the rich vq API which was explicitly designed for the driver > > running the device being responsible for serializing accesses. Which is > > actually loaded and running. And I *think* your use won't conflict ATM > > mostly by luck. Witness the hack in patch 01 as exhibit 1 - nothing > > at all even hints at the fact that the reason for the complicated > > dance is because another driver pokes at some of the vqs. > > Fully agreed. The smart nic vendors are trying to do the same mess > in nvme, and we really need to stop them and agree on proper standarized > live migration features implemented in the core virtio/nvme code. ??? This patch series is an implementation of changes that OASIS approved. The live migration work is going to OASIS first no patches have been presented. This thread is arguing about how to split up the code for the implementatin of the standard given that VFIO owns the VF and the virtio core owns the PF. The standard defined that PF admin queue operations are needed to do operations on behalf of the VF. Jason
