On 7/25/2023 10:29 AM, Simon Horman wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
On Wed, Jul 19, 2023 at 03:35:25PM -0700, Brett Creeley wrote:
...
+static void pds_vfio_dirty_free_bitmaps(struct pds_vfio_dirty *dirty)
+{
+ if (dirty->host_seq.bmp)
+ vfree(dirty->host_seq.bmp);
+ if (dirty->host_ack.bmp)
+ vfree(dirty->host_ack.bmp);
Hi Brett,
I don't think there is a need to guard these vfree calls,
as I think they will be no-ops with NULL arguments.
Another good catch. I will also fix this for v13. Thanks for the review.
Brett
+
+ dirty->host_seq.bmp = NULL;
+ dirty->host_ack.bmp = NULL;
+}
...
