On 7/25/2023 10:31 AM, Simon Horman wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
On Wed, Jul 19, 2023 at 03:35:24PM -0700, Brett Creeley wrote:
...
diff --git a/drivers/vfio/pci/pds/lm.c b/drivers/vfio/pci/pds/lm.c
...
+static int pds_vfio_get_save_file(struct pds_vfio_pci_device *pds_vfio)
+{
+ struct device *dev = &pds_vfio->vfio_coredev.pdev->dev;
+ struct pds_vfio_lm_file *lm_file;
+ int err;
+ u64 size;
Hi Brett,
please use reverse xmas tree - longest line to shortest -
for these local variable declarations.
https://github.com/ecree-solarflare/xmastree is your friend here.
Ah, good catch and thanks for the reference. Will fix on v13.
