Re: [PATCH v12 vfio 5/7] vfio/pds: Add support for dirty page tracking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 19, 2023 at 03:35:25PM -0700, Brett Creeley wrote:

...

> +static void pds_vfio_dirty_free_bitmaps(struct pds_vfio_dirty *dirty)
> +{
> +	if (dirty->host_seq.bmp)
> +		vfree(dirty->host_seq.bmp);
> +	if (dirty->host_ack.bmp)
> +		vfree(dirty->host_ack.bmp);

Hi Brett,

I don't think there is a need to guard these vfree calls,
as I think they will be no-ops with NULL arguments.

> +
> +	dirty->host_seq.bmp = NULL;
> +	dirty->host_ack.bmp = NULL;
> +}

...




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux