On Tue, Oct 18, 2022, Like Xu wrote: > Most of the comments will be addressed in the next version. > > On 6/10/2022 3:14 am, Sean Christopherson wrote: > > On Thu, Jul 28, 2022, Like Xu wrote: > > > +#include "vm.h" > > > +#include "types.h" > > > +#include "processor.h" > > > +#include "vmalloc.h" > > > +#include "alloc_page.h" > > > + > > > +#define PC_VECTOR 32 > > > > PC? > > Part of legacy code, may be "performance counter vector" ? Ah, it comes from the LVT Performance Counter Register". > It will be reused in the new lib/pmu.h. Any objection to renaming it to PMI_VECTOR? That's much more familiar for KVM developers and it's still correct, e.g. it's the PMI vector that's programmed into the LVT PC register.