On 9/22/20 10:17 AM, Stefan Hajnoczi wrote: > On Mon, Sep 21, 2020 at 01:56:08PM -0700, no-reply@xxxxxxxxxxx wrote: >> ERROR: Macros with multiple statements should be enclosed in a do - while loop >> #2968: FILE: include/qemu/atomic.h:152: >> +#define qemu_atomic_rcu_read__nocheck(ptr, valptr) \ >> __atomic_load(ptr, valptr, __ATOMIC_RELAXED); \ >> smp_read_barrier_depends(); >> ... >> WARNING: Block comments use a leading /* on a separate line >> #7456: FILE: util/rcu.c:154: >> + /* In either case, the qemu_atomic_mb_set below blocks stores that free >> >> total: 7 errors, 4 warnings, 6507 lines checked > > These are pre-existing coding style issues. This is a big patch that > tries to make as few actual changes as possible so I would rather not > try to fix them. What I do with automated patches triggering checkpatch errors: - run automated conversion - fix errors until checkpatch is happy - run automated conversion inversed - result is the checkpatch changes, commit them - run automated conversion again, commit
