On Mon, Sep 21, 2020 at 01:56:08PM -0700, no-reply@xxxxxxxxxxx wrote: > ERROR: Macros with multiple statements should be enclosed in a do - while loop > #2968: FILE: include/qemu/atomic.h:152: > +#define qemu_atomic_rcu_read__nocheck(ptr, valptr) \ > __atomic_load(ptr, valptr, __ATOMIC_RELAXED); \ > smp_read_barrier_depends(); > > ERROR: space required before that '*' (ctx:VxB) > #3123: FILE: include/qemu/atomic.h:347: > +#define qemu_atomic_read__nocheck(p) (*(__typeof__(*(p)) volatile*) (p)) > ^ > > ERROR: Use of volatile is usually wrong, please add a comment > #3123: FILE: include/qemu/atomic.h:347: > +#define qemu_atomic_read__nocheck(p) (*(__typeof__(*(p)) volatile*) (p)) > > ERROR: space required before that '*' (ctx:VxB) > #3125: FILE: include/qemu/atomic.h:349: > + ((*(__typeof__(*(p)) volatile*) (p)) = (i)) > ^ > > ERROR: Use of volatile is usually wrong, please add a comment > #3125: FILE: include/qemu/atomic.h:349: > + ((*(__typeof__(*(p)) volatile*) (p)) = (i)) > > ERROR: space required after that ',' (ctx:VxV) > #3130: FILE: include/qemu/atomic.h:352: > +#define qemu_atomic_set(ptr, i) qemu_atomic_set__nocheck(ptr,i) > ^ > > ERROR: memory barrier without comment > #3205: FILE: include/qemu/atomic.h:410: > +#define qemu_atomic_xchg(ptr, i) (smp_mb(), __sync_lock_test_and_set(ptr, i)) > > WARNING: Block comments use a leading /* on a separate line > #3280: FILE: include/qemu/atomic.h:462: > +/* qemu_atomic_mb_read/set semantics map Java volatile variables. They are > > WARNING: Block comments use a leading /* on a separate line > #6394: FILE: util/bitmap.c:214: > + /* If we avoided the full barrier in qemu_atomic_or(), issue a > > WARNING: Block comments use a leading /* on a separate line > #7430: FILE: util/rcu.c:85: > + /* Instead of using qemu_atomic_mb_set for index->waiting, and > > WARNING: Block comments use a leading /* on a separate line > #7456: FILE: util/rcu.c:154: > + /* In either case, the qemu_atomic_mb_set below blocks stores that free > > total: 7 errors, 4 warnings, 6507 lines checked These are pre-existing coding style issues. This is a big patch that tries to make as few actual changes as possible so I would rather not try to fix them. Stefan
Attachment:
signature.asc
Description: PGP signature
