> On 16 Apr 2019, at 20:27, Sean Christopherson <sean.j.christopherson@xxxxxxxxx> wrote: > > On Tue, Apr 16, 2019 at 07:48:42PM +0300, Liran Alon wrote: > Yes I understood that already. >> I don’t think it contradicts the fact that the checks I mentioned above >> should be moved out of start_hv_timer(). > > Ah, I misread your comment. I think. My head is spinning trying to > work through this code. > >>> I think Paolo's suggestion of moving the logic up into restart_apic_timer() >>> is the way to go as it reduces the multiplexing down on start_hv_timer()'s >>> return value. >>> >> >> Yes I agree. I plan to do so. > > And because I misread your comment, I already created this patch. I'll > send it out shortly. LOL OK. :) Be my guest. -Liran
