On 14/04/19 14:15, Liran Alon wrote: > In addition, when start_hv_timer() returns false, > restart_apic_timer() just calls start_sw_timer() which use hrtimer > instead of VMX preemption timer. Therefore, it seems a bit > ineffective to me for start_hv_timer() to return false in case > ktimer->pending or when ktimer->tscdeadline already expired. > Shouldn’t we return true in these cases? Since start_hv_timer is only called from restart_apic_timer, I suggest doing that check in restart_apic_timer itself. Paolo
