On 17/12/18 11:30, Vitaly Kuznetsov wrote: >> Queued, thanks. I moved this above the direct EOI series so that >> KVM_CAP_HYPERV_STIMER_DIRECT need not exist at any point of the history. >> > Thanks! Just to make sure (and to conclude our discussion with Roman): > with your Qemu maintainer hat on, do you agree with the design decision > that KVM_GET_SUPPORTED_HV_CPUID's output value changes when > KVM_CAP_HYPERV_ENLIGHTENED_VMCS gets enabled? This differs from > KVM_GET_SUPPORTED_CPUID (where we always list all feature bits even if > they require explicit enablement)? It doesn't really matter, since the old capability cannot be removed. If you want to change it with a patch on top, that's also okay with me. Paolo