----- pbonzini@xxxxxxxxxx wrote: > On 16/03/2018 17:30, Radim Krčmář wrote: > > 2018-03-16 08:59-0700, Liran Alon: > >> ----- rkrcmar@xxxxxxxxxx wrote: > >>> We fall through and return true for 0x33 with opcode_len == 1, > >>> plase add a break. > >> > >> Oops. Nice catch. Will add missing break instruction of course. > >> Do you want to add it on apply or should I re-submit the series > with this fix? > > > > I think Paolo will add it. I didn't notice any other problems and > > resubmitting the series would be an overkill. > > > > With that, consider the series > > > > Reviewed-by: Radim Krčmář <rkrcmar@xxxxxxxxxx> > > > > I'm sad that the backdoor ports behave like this, but you handled > it > > nicely. > > > > ... just one thing, the SoB chain is messed up. I can fix it, but I > need the answers to these questions: > > 1) who wrote the first six patches, you (Liran) or Krish Sadhukhan? I wrote them. Because of internal legal agreements on how to submit patches on Oracle, I need someone from another internal organization in Oracle to review the patch and add it's signoff to the patch (In addition to mine). You can see that all of my previous patches to KVM which were already merged looks similar. > > 2) why do the last 4 patches have Konrad's SoB? Same reason. They both reviewed it. You can take only one of them. > > 3) why does the last patch lack your SoB, and who wrote it, you or > Arbel? Arbel wrote the last patch. That's why I didn't put my SoB on it. It does contain the SoB of Konrad which reviewed it because of the legal agreement. Sorry for the confusion... > > Thanks! > > Paolo
