On 16/03/2018 17:56, Liran Alon wrote: >> 1) who wrote the first six patches, you (Liran) or Krish Sadhukhan? > I wrote them. > Because of internal legal agreements on how to submit patches on Oracle, > I need someone from another internal organization in Oracle to review the > patch and add it's signoff to the patch (In addition to mine). > You can see that all of my previous patches to KVM which were already > merged looks similar. > >> 2) why do the last 4 patches have Konrad's SoB? > Same reason. They both reviewed it. You can take only one of them. The signoff has a specific meaning, that is one of the following: - the patch is your work and you have the right to submit it to Linux (under an appropriate license), - the patch is based on work that you know you have the right to submit to Linux, - the patch was provided to you by someone else who had signed-off the work before. (The short legalese is at https://developercertificate.org/). So if people "sign off" internally for upstream submission you don't need to put their Signed-off-by line. >> 3) why does the last patch lack your SoB, and who wrote it, you or >> Arbel? > Arbel wrote the last patch. > That's why I didn't put my SoB on it. > It does contain the SoB of Konrad which reviewed it because of the legal agreement. If you send it, you do need to add your sign off, just like I add mine before sending it to Linus. Konrad's review again doesn't matter. Paolo
