On Thu, Nov 10, 2016 at 09:10:14PM +0100, Andrew Jones wrote: [...] > > +bool pci_setup_msi(struct pci_dev *dev, uint64_t msi_addr, uint32_t msi_data) > > +{ > > + uint16_t msi_control; > > + uint16_t offset; > > + pcidevaddr_t addr = dev->bdf; > > + > > + assert(dev); > > If you're worried that dev might be null then you can't dereference > it the line above. Right. Fixing up. Thanks, -- peterx -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html