Re: [PATCH kvm-unit-tests v2 14/17] x86: intel-iommu: add dmar test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 10, 2016 at 08:53:02PM +0100, Andrew Jones wrote:

[...]

> > +/* Supported Adjusted Guest Address Widths */
> > +#define VTD_CAP_SAGAW_SHIFT         8
> > + /* 39-bit AGAW, 3-level page-table */
> > +#define VTD_CAP_SAGAW_39bit         (0x2ULL << VTD_CAP_SAGAW_SHIFT)
> > + /* 48-bit AGAW, 4-level page-table */
> 
> The leading space in the above comments is a bit strange

Yes, they are. :)

[...]

> > +	/*
> > +	 * DMA the first 4 bytes of the page to EDU device buffer
> > +	 * offset 0.
> > +	 */
> > +	edu_dma(dev, 0, 4, 0, false);
> 
> missing blank line here

Will fix both. Thanks,

-- peterx
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux