On 18/11/2015 06:44, Huaitong Han wrote: > This patch disables CPUID:PKU without ept, becase pkeys is not supported > with softmmu. Sure, but _what_ makes it impossible to support pkeys with shadow pages? Is it enough to add the pkey bits to the role (and then to kvm_get_mmu_page, mmu_set_spte, set_spte) or are there fundamental problems? The trick to handle !CR0.WP in FNAME(page_fault) (search for "walker.pte_access &= ~ACC_USER_MASK"; it's documented in Documentation/virtual/kvm/mmu.txt as well) should work for PKRU. If you just want me to change it to "is not yet implemented for shadow paging", I can do that. Thanks, Paolo > Signed-off-by: Huaitong Han <huaitong.han@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html