On Wed, 2015-11-18 at 10:06 +0100, Paolo Bonzini wrote:
>
> On 18/11/2015 06:44, Huaitong Han wrote:
> > This patch disables CPUID:PKU without ept, becase pkeys is not
> > supported
> > with softmmu.
>
> Sure, but _what_ makes it impossible to support pkeys with shadow
> pages?
>
> Is it enough to add the pkey bits to the role (and then to
> kvm_get_mmu_page, mmu_set_spte, set_spte) or are there fundamental
> problems?
>
> The trick to handle !CR0.WP in FNAME(page_fault) (search for
> "walker.pte_access &= ~ACC_USER_MASK"; it's documented in
> Documentation/virtual/kvm/mmu.txt as well) should work for PKRU.
>
> If you just want me to change it to "is not yet implemented for
> shadow
> paging", I can do that.
Yes, the comments should be described as "becase pkeys is not yet
implemented for shadow paging."
Thanks
Huaitong.
>
> Thanks,
>
> Paolo
>
> > Signed-off-by: Huaitong Han <huaitong.han@xxxxxxxxx>��.n��������+%������w��{.n�����o�^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
