Hi Riku, On 04/09/15 11:52, Riku Voipio wrote: > On 4 September 2015 at 13:10, Andre Przywara <andre.przywara@xxxxxxx> wrote: >> Hi Riku, >> >> On 03/09/15 12:20, riku.voipio@xxxxxxxxxx wrote: >>> From: Riku Voipio <riku.voipio@xxxxxxxxxx> >>> >>> Currently Makefile accepts only armv7l.* When building kvmtool under 32bit >>> personality on Aarch64 machines, uname -m reports "armv8l", so build fails. >>> We expect doing 32bit arm builds in Aarch64 to become standard the same way >>> people do i386 builds on x86_64 machines. >>> >>> Make the sed test a little more greedy so armv8l becomes acceptable. >>> >>> Signed-off-by: Riku Voipio <riku.voipio@xxxxxxxxxx> >> >> The patch looks OK to me, I just wonder how you do the actual build >> within the linux32 environment? >> Do you have an arm cross compiler installed and set CROSS_COMPILE? Or is >> there a magic compiler (driver) which uses uname -m as well? >> And what would be the difference to setting ARCH=arm as well? Just >> convenience? > > It's just an arm32 chroot, with an native arm32 compiler. The chroot > is on an arm64 machine since these tend to be much faster than arm32 > hardware. Oh right, a chroot, didn't think about the obvious ;-) Also it applies to 64-bit kernels with 32-bit root filesystems, I think. So: Acked-by: Andre Przywara <andre.przywara@xxxxxxx> Cheers, Andre. > > It would of course be possible to set ARCH=arm, but that would mean > some ifdefs in the Debian packaging, since the same build rule should > work for all architectures. > > Riku > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
