Hi Riku, On 03/09/15 12:20, riku.voipio@xxxxxxxxxx wrote: > From: Riku Voipio <riku.voipio@xxxxxxxxxx> > > Currently Makefile accepts only armv7l.* When building kvmtool under 32bit > personality on Aarch64 machines, uname -m reports "armv8l", so build fails. > We expect doing 32bit arm builds in Aarch64 to become standard the same way > people do i386 builds on x86_64 machines. > > Make the sed test a little more greedy so armv8l becomes acceptable. > > Signed-off-by: Riku Voipio <riku.voipio@xxxxxxxxxx> The patch looks OK to me, I just wonder how you do the actual build within the linux32 environment? Do you have an arm cross compiler installed and set CROSS_COMPILE? Or is there a magic compiler (driver) which uses uname -m as well? And what would be the difference to setting ARCH=arm as well? Just convenience? Cheers, Andre. > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 1534e6f..7b17d52 100644 > --- a/Makefile > +++ b/Makefile > @@ -103,7 +103,7 @@ OBJS += hw/i8042.o > > # Translate uname -m into ARCH string > ARCH ?= $(shell uname -m | sed -e s/i.86/i386/ -e s/ppc.*/powerpc/ \ > - -e s/armv7.*/arm/ -e s/aarch64.*/arm64/ -e s/mips64/mips/) > + -e s/armv.*/arm/ -e s/aarch64.*/arm64/ -e s/mips64/mips/) > > ifeq ($(ARCH),i386) > ARCH := x86 > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
