Re: [kvm-unit-tests PATCH] scripts/arch-run: Mark migration tests as SKIP if ncat is not available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 12/21/21 11:12, Thomas Huth wrote:
On 21/12/2021 10.58, Paolo Bonzini wrote:
On 12/21/21 10:21, Thomas Huth wrote:
Instead of failing the tests, we should rather skip them if ncat is
not available.
While we're at it, also mention ncat in the file as a
requirement for the migration tests.

Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>

I would rather remove the migration tests.  There's really no reason for them, the KVM selftests in the Linux tree are much better: they can find migration bugs deterministically and they are really really easy to debug. The only disadvantage is that they are harder to write.

I disagree: We're testing migration with QEMU here - the KVM selftests don't include QEMU, so we'd lose some test coverage here. And at least the powerpc/sprs.c test helped to find some nasty bugs in the past already.

I understand that this is testing QEMU, but I'm not sure that testing QEMU should be part of kvm-unit-tests. Migrating an instance of QEMU that runs kvm-unit-tests would be done more easily in avocado-vt or avocado-qemu.


[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux