Hi, On 12/21/21 11:12 AM, Thomas Huth wrote: > On 21/12/2021 10.58, Paolo Bonzini wrote: >> On 12/21/21 10:21, Thomas Huth wrote: >>> Instead of failing the tests, we should rather skip them if ncat is >>> not available. >>> While we're at it, also mention ncat in the README.md file as a >>> requirement for the migration tests. >>> >>> Resolves: https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/issues/4 >>> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx> >> >> I would rather remove the migration tests. There's really no reason >> for them, the KVM selftests in the Linux tree are much better: they >> can find migration bugs deterministically and they are really really >> easy to debug. The only disadvantage is that they are harder to write. > > I disagree: We're testing migration with QEMU here - the KVM selftests > don't include QEMU, so we'd lose some test coverage here. > And at least the powerpc/sprs.c test helped to find some nasty bugs in > the past already. I do agree. The ITS migration tests were good reproducer for upstream bugs. Thanks Eric > > Thomas >
