Re: [kvm-unit-tests PATCH] scripts/arch-run: Mark migration tests as SKIP if ncat is not available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 12/21/21 10:21, Thomas Huth wrote:
Instead of failing the tests, we should rather skip them if ncat is
not available.
While we're at it, also mention ncat in the file as a
requirement for the migration tests.

Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>

I would rather remove the migration tests. There's really no reason for them, the KVM selftests in the Linux tree are much better: they can find migration bugs deterministically and they are really really easy to debug. The only disadvantage is that they are harder to write.


---             | 4 ++++
  scripts/arch-run.bash | 2 +-
  2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/ b/
index 6e6a9d0..a82da56 100644
--- a/
+++ b/
@@ -54,6 +54,10 @@ ACCEL=name environment variable:
ACCEL=kvm ./x86-run ./x86/msr.flat +For running tests that involve migration from one QEMU instance to another
+you also need to have the "ncat" binary (from the project) installed,
+otherwise the related tests will be skipped.
  # Tests configuration file
The test case may need specific runtime configurations, for
diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
index 43da998..cd92ed9 100644
--- a/scripts/arch-run.bash
+++ b/scripts/arch-run.bash
@@ -108,7 +108,7 @@ run_migration ()
  	if ! command -v ncat >/dev/null 2>&1; then
  		echo "${FUNCNAME[0]} needs ncat (netcat)" >&2
-		return 2
+		return 77
migsock=$(mktemp -u -t mig-helper-socket.XXXXXXXXXX)

[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux