Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



在 2022/3/29 15:07, Marc Zyngier 写道:

On Tue, 29 Mar 2022 07:14:16 +0100,
yuzhe <yuzhe@xxxxxxxxxxxx> wrote:
@@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,
     static int vgic_debug_show(struct seq_file *s, void *v)
   {
-	struct kvm *kvm = (struct kvm *)s->private;
+	struct kvm *kvm = s->private;
   	struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
How about you fully get rid of the unnecessary casts then?

	M.
I don't know what you exactly mean. I follow the
kernel-janitors/TODO List to get rid of the unnecessary casts.  And
I checked all the code in the arch directory and found these issues.
Let me quote the lines again:

     static int vgic_debug_show(struct seq_file *s, void *v)
[...]
   	struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
Do you see what I mean?

	M.

Got it, thanks. I will check again and resubmit.

yuzhe

_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm




[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux