On Mon, 28 Mar 2022 11:38:36 +0100, yuzhe <yuzhe@xxxxxxxxxxxx> wrote: > > remove unnecessary castings, from "void *" to "struct kvm *" > > Signed-off-by: yuzhe <yuzhe@xxxxxxxxxxxx> > --- > arch/arm64/kvm/vgic/vgic-debug.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic-debug.c > index f38c40a76251..927e5c1f650d 100644 > --- a/arch/arm64/kvm/vgic/vgic-debug.c > +++ b/arch/arm64/kvm/vgic/vgic-debug.c > @@ -82,7 +82,7 @@ static bool end_of_vgic(struct vgic_state_iter *iter) > > static void *vgic_debug_start(struct seq_file *s, loff_t *pos) > { > - struct kvm *kvm = (struct kvm *)s->private; > + struct kvm *kvm = s->private; > struct vgic_state_iter *iter; > > mutex_lock(&kvm->lock); > @@ -110,7 +110,7 @@ static void *vgic_debug_start(struct seq_file *s, loff_t *pos) > > static void *vgic_debug_next(struct seq_file *s, void *v, loff_t *pos) > { > - struct kvm *kvm = (struct kvm *)s->private; > + struct kvm *kvm = s->private; > struct vgic_state_iter *iter = kvm->arch.vgic.iter; > > ++*pos; > @@ -122,7 +122,7 @@ static void *vgic_debug_next(struct seq_file *s, void *v, loff_t *pos) > > static void vgic_debug_stop(struct seq_file *s, void *v) > { > - struct kvm *kvm = (struct kvm *)s->private; > + struct kvm *kvm = s->private; > struct vgic_state_iter *iter; > > /* > @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq, > > static int vgic_debug_show(struct seq_file *s, void *v) > { > - struct kvm *kvm = (struct kvm *)s->private; > + struct kvm *kvm = s->private; > struct vgic_state_iter *iter = (struct vgic_state_iter *)v; How about you fully get rid of the unnecessary casts then? M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm