On Tue, 29 Mar 2022 07:14:16 +0100, yuzhe <yuzhe@xxxxxxxxxxxx> wrote: > > >> @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq, > >> static int vgic_debug_show(struct seq_file *s, void *v) > >> { > >> - struct kvm *kvm = (struct kvm *)s->private; > >> + struct kvm *kvm = s->private; > >> struct vgic_state_iter *iter = (struct vgic_state_iter *)v; > > How about you fully get rid of the unnecessary casts then? > > > > M. > > I don't know what you exactly mean. I follow the > kernel-janitors/TODO List to get rid of the unnecessary casts. And > I checked all the code in the arch directory and found these issues. Let me quote the lines again: > >> static int vgic_debug_show(struct seq_file *s, void *v) [...] > >> struct vgic_state_iter *iter = (struct vgic_state_iter *)v; Do you see what I mean? M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm