On Thu, Jun 14, 2012 at 12:00 PM, Peter Maydell <peter.maydell at linaro.org> wrote: > On 14 June 2012 05:48, Christoffer Dall <c.dall at virtualopensystems.com> wrote: >> @@ -694,8 +694,51 @@ int kvm_emulate_mmio_ls(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, >> >> ? ? ? ?/* >> ? ? ? ? * The MMIO instruction is emulated and should not be re-executed >> - ? ? ? ?* in the guest. (XXX We don't support Thumb instructions yet). >> + ? ? ? ?* in the guest. >> ? ? ? ? */ > > Can we actually remove this XXX yet? > yeah, we can remove from here. There's another comment and a printk in the place where it really hurts. > One amusing edge case which I think I've mentioned before: 32 bit > Thumb instructions can cross page boundaries, which means the two > halves may not be at consecutive IPAs. invalid_io_mem_abort() > currently assumes they are... > see https://github.com/virtualopensystems/linux-kvm-arm/commit/58b6398eec36514dd51e6977c516eaa1c8c5bb3b. -Christoffer
