On 14 June 2012 05:48, Christoffer Dall <c.dall at virtualopensystems.com> wrote: > @@ -694,8 +694,51 @@ int kvm_emulate_mmio_ls(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > > ? ? ? ?/* > ? ? ? ? * The MMIO instruction is emulated and should not be re-executed > - ? ? ? ?* in the guest. (XXX We don't support Thumb instructions yet). > + ? ? ? ?* in the guest. > ? ? ? ? */ Can we actually remove this XXX yet? One amusing edge case which I think I've mentioned before: 32 bit Thumb instructions can cross page boundaries, which means the two halves may not be at consecutive IPAs. invalid_io_mem_abort() currently assumes they are... -- PMM
