On Wed, Dec 7, 2011 at 2:01 PM, Antonios Motakis <a.motakis at virtualopensystems.com> wrote: > I'm not sure I agree with this particular change; take for example some > potential contributor pulling from the git tree, and blissfully building > the bootwrapper, unaware that his host IP address is included > automagically. This could result in confusion when that same user > changes the host IP address and ends up being unable to boot the system > without knowing why. I'm not too concerned about this and if the IP address changes, the script uses the new IP address. > > So I'd rather have the user include his IP address explicitly. Compared > to all the pains one has to go to setup NFS in the first place, editing > a Makefile or config file is trivial anyway. > I think the idea is to let uses put the script in their config file if they want or put a hard-coded address in their config file. There can be a config.sample that has everything commented out and users have to edit things in explicitly. My point of view is to make things as easy as possible for the common case and keeping configuration changes away from git commit changes.
