I'm not sure I agree with this particular change; take for example some potential contributor pulling from the git tree, and blissfully building the bootwrapper, unaware that his host IP address is included automagically. This could result in confusion when that same user changes the host IP address and ends up being unable to boot the system without knowing why. So I'd rather have the user include his IP address explicitly. Compared to all the pains one has to go to setup NFS in the first place, editing a Makefile or config file is trivial anyway. Also, this assumes that the NFS server used is the same as the host, which might not be the case. For example I could be syncing my dev environment between my desktop and laptop, but I might keep the NFS filesystem only on the desktop. Etc. Anyway in any case, I didn't notice that small change before, so I'll keep it in mind to update the guide accordingly. Best regards, Antonios On 12/07/2011 04:11 PM, Christoffer Dall wrote: > On Wed, Dec 7, 2011 at 10:07 AM, Peter Maydell<peter.maydell at linaro.org> wrote: >> On 7 December 2011 15:04, Christoffer Dall<cdall at cs.columbia.edu> wrote: >>> On Wed, Dec 7, 2011 at 10:02 AM, Peter Maydell<peter.maydell at linaro.org> wrote: >>>> In fact patch 6 fixes this, because the 'force' dependency on the >>>> $(KERNEL_SRC)/arch/arm/boot/uImage target means we will always run >>>> the rule for that target, ie we will always invoke the kernel makefile >>>> and ask it to make sure the uImage is up to date. (I just tested this >>>> and it does do the right thing.) >>>> >>>> I hadn't spotted this wrinkle, or I'd have combined the two patches >>>> somehow instead. >>> And I missed the other one. OK, we're in agreement. >> Do you want me to redo the patchset to combine the two patches? >> > I don't care too much either way, as long as it's included. > > Since you re-based on Marc's tree, I assumed he would merge how he wanted to? > > I actually added a small change in my repo > (https://github.com/virtualopensystems/boot-wrapper/commits/master) to > discover the host IP for nfs boots at compile time. Take a look and > tell me if it's something you think we should merge as well. > > -Christoffer > _______________________________________________ > Android-virt mailing list > Android-virt at lists.cs.columbia.edu > https://lists.cs.columbia.edu/cucslists/listinfo/android-virt
