[Android-virt] [PATCH 1/6] Makefile: Improve $(KERNEL) target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 5, 2011 at 12:47 PM, Peter Maydell <peter.maydell at linaro.org> wrote:
> Minor tweaks to the $(KERNEL) target:
> ?* use $(MAKE) so -n &c work better
> ?* depend on the uImage which we use, not the zImage which we don't

I don't appreciate this. Simple 'make' in the kernel dir produces a
zImage, which is what I try to pick up - I think hack, make, hack,
make, etc. is a pretty standard work flow and uImage needs zImage to
be written as well, so 'make uImage' will also produce a zImage...

> ?* use automatic variables to avoid repeating the path to uImage
> ?* drop unnecessary separate cd
> ?* fix stray direct use of "../linux-kvm-arm"
>
> Signed-off-by: Peter Maydell <peter.maydell at linaro.org>
> ---
> ?Makefile | ? ?6 +++---
> ?1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 6dc9912..3d74ac0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -35,9 +35,9 @@ all: $(IMAGE)
> ?clean:
> ? ? ? ?rm -f $(IMAGE) boot.o model.lds monitor.o uImage
>
> -$(KERNEL): ../linux-kvm-arm/arch/arm/boot/zImage
> - ? ? ? cd $(KERNEL_SRC); make -j4 uImage
> - ? ? ? cp $(KERNEL_SRC)/arch/arm/boot/uImage $(KERNEL)
> +$(KERNEL): $(KERNEL_SRC)/arch/arm/boot/uImage
> + ? ? ? $(MAKE) -C $(KERNEL_SRC) -j4 uImage
> + ? ? ? cp $< $@
>
> ?$(IMAGE): boot.o monitor.o model.lds $(KERNEL) $(FILESYSTEM) Makefile
> ? ? ? ?$(LD) -o $@ --script=model.lds
> --
> 1.7.5.4
>



[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux