On Tue, Oct 29, 2013 at 11:04:28AM +0900, Simon Horman wrote: [..] > > > Yes, that's my point. You're breaking old configurations by requiring > > > the user to pass an additional argument. > > > > Yes this is a problem. Of course solution is easy by always passing > > acpi_rsdp on command line. But in long term this is a problem. In the > > sense, I am not sure how to cleanup the kexec-tools code as things improve. > > Now we will support the EFI properly and still pass acpi_rsdp always in > > an effort to matain backward compatibility. > > > > For a very long time kexec-tools were not automatically appending > > acpi_rsdp and user were supposed to add it on command line. We were > > carrying this change in kdump scripts and pushed this change into > > kexec-tools. In hindsight, it looks like that hardcoding parameters > > in kexec-tools is a bad idea. It is hard to get rid of them in future. > > I tend to agree. However, if the parameters end up being hard coded > elsewhere, for example in widely used wrapper scripts, then I think that > the same problem still exists. Just outside of kexec-tools itself. I think getting rid of them in vendor scripts is easier beacause control the range of kexec-tools and kernel version which will be used in a particular release life cycle. So when we know that we are not going to support other kernels than vendor shipped kernel, we can remove parameters from scripts. Thanks Vivek
