Hi, Thanks for review. On 10/28/13 at 09:42am, Matthew Garrett wrote: > On Sun, Oct 27, 2013 at 12:04:39PM +0800, dyoung at redhat.com wrote: > > Removing code to pass acpi_rsdp because this > > patch series will support efi runtime, it's not > > necessary any more. EFI initialization code will > > take the functionality. > > Won't this break kexec of old kernels that don't have the new UEFI setup > code? For old kernels the efi setup_data esdata will be NULL, it wil switch to old logic. Also for old kernel user need to pass acpi_rsdp in cmdline Anyway I will do test with old/new kernel/userspace test results. -- Thanks Dave