On 10/28/13 at 10:12am, Matthew Garrett wrote: > On Mon, Oct 28, 2013 at 05:54:59PM +0800, Dave Young wrote: > > Hi, > > Thanks for review. > > > > On 10/28/13 at 09:42am, Matthew Garrett wrote: > > > On Sun, Oct 27, 2013 at 12:04:39PM +0800, dyoung at redhat.com wrote: > > > > Removing code to pass acpi_rsdp because this > > > > patch series will support efi runtime, it's not > > > > necessary any more. EFI initialization code will > > > > take the functionality. > > > > > > Won't this break kexec of old kernels that don't have the new UEFI setup > > > code? > > > > For old kernels the efi setup_data esdata will be NULL, it wil switch to > > old logic. Also for old kernel user need to pass acpi_rsdp in cmdline > > Right, but previously acpi_rsdp was passed automatically and now it > won't be? Yes, it was. I'm removing them in kexec-tools patches for efi runtime support. Correct myself about esdata, for old kernels there's no setup_data type for efi so parse_efi_setup will not be called, thus there will be no effect with passing new setup_data because nobody use it?
