> > > > > > +void __init parse_efi_setup(u64 phys_addr) > > > +{ > > > + struct setup_data *sd; > > > + > > > + if (!efi_enabled(EFI_64BIT)) { > > > + pr_warn("SETUP_EFI not supported on 32-bit\n"); > > > + return; > > > + } > > > > Shouldn't this function be in two versions in efi_64.c and efi_32.c? > > This way you don't need this check with cryptic printk message. > > Ok, will update. Rethink about this issue, moving them to efi_$(BITS).c I need move the efi_setup from a static variable to an extern, It looks not worth. Thanks Dave