> > > + */
> > > +static int __init map_regions_fixed(void)
> > > +{
> > > + int i, s, ret = 0;
> > > + u64 end, systab;
> > > + unsigned long size;
> > > + efi_memory_desc_t *md;
> > > + struct efi_setup_data *data;
> > > +
> > > + s = sizeof(*data) + nr_efi_runtime_map * sizeof(data->map[0]);
> > > + data = early_memremap(efi_setup, s);
> > > + if (!data) {
> > > + ret = -ENOMEM;
> > > + goto out;
> > > + }
> >
> > newline.
>
> Will remove
misread the comment, there's no new line here. Looks like you want a
new blank line here, ok..
>
> >
> > > + for (i = 0, md = data->map; i < nr_efi_runtime_map; i++, md++) {
> > > + efi_map_region_fixed(md); /* FIXME: add error handling */
> > > + size = md->num_pages << PAGE_SHIFT;
> > > + end = md->phys_addr + size;
> > > +
> > > + systab = (u64) (unsigned long) efi_phys.systab;
> > > + if (md->phys_addr <= systab && systab < end) {
> > > + systab += md->virt_addr - md->phys_addr;
> > > + efi.systab = (efi_system_table_t *)(unsigned long)systab;
> > > + }
> > > + ret = save_runtime_map(md, i);
> >
