> > > > > and the EFI_BOOT* tests can be done in save_runtime_map and also the > > error handling can happen there. This way efi_map_regions() won't > > need to know about anything. This way, you can later move the whole > > save_runtime_map() function to efi-kexec.c just by taking it without any > > need for untangling. > > > > > +out_save_runtime: > > > + kfree(efi_runtime_map); > > > + nr_efi_runtime_map = 0; > > > + efi_runtime_map = NULL; > > > > This can go there too. > > This section can go the save_runtime_map but it looks clearer to put them here. BTW, I will restructure the whole code when I move them to efi_kexec.c, so no worry about it? If you have strong opinion I can move them though. Thanks Dave
