Hi, Ohmichi-san
Thank you for your review.
>> Akio Takebe wrote:
>>> Curret kdump-xen with makdumpfile always return 0.
>>> So if we fail to kdump, we will get $?=0.
>>> This patch improve it.
>>>
>>> Signed-off-by: Akio Takebe <takebe_akio at jp.fujitsu.com>
>>>
>>> --- makedumpfile/makedumpfile.c 2008-03-28 11:32:51.000000000 +0900
>>> +++ makedumpfile.mod/makedumpfile.c 2008-04-01 02:14:12.000000000 +0900
>>> @@ -993,6 +993,8 @@ get_symbol_addr(char *symname)
>>> if (!strcmp(sym_name, symname)) {
>>> symbol = sym.st_value;
>>> break;
>>> + } else if (i >= (shdr.sh_size/shdr.sh_entsize)-1) {
>>> + DEBUG_MSG("Can't get symbol of %s.\n", symname);
>>
>> This patch is for fixing error code of xen, but the above code adds
>> the debugging message. So the above code doesn't match its purpose.
>> Is it necessary ?
>
>Sorry for incomprehensible comment.
>
>The existences of symbols depend on linux version, cpu architecture,
>and linux configuration (.config file). If the above code is merged,
>the debugging message will be big and unreadable.
>Do you want to know the lacks of necessary symbol for dump filtering
>of Xen ? -D option prints them.
>
Yes, that's right.
The concept of this hunk is to catch error at making vmcoreinfo file.
Current vmcoreinfo doesn't show error if some necessary symbols are not included.
Then we will find it at failing kdump.
So I wanted to add the debug message into the function finding symbol.
Since the hunk is not important, please drop it.
Best Regards,
Akio Takebe
