Hi, Ohmichi-san
>
>> - return handle_xen();
>> + if (!handle_xen())
>> + goto out;
>
>I guess that the above code is not enough. If handle_xen() succeeds,
>it should return TRUE instead of COMPLETED like the attached patch, right ?
You're right!
Your patch looks good, thank you very much for your review.
Best Regards,
Akio Takebe
>
>
>Thanks
>Ken'ichi Ohmichi
>
>Signed-off-by: Akio Takebe <takebe_akio at jp.fujitsu.com>
>Signed-off-by: Ken'ichi Ohmichi <oomichi at mxs.nes.nec.co.jp>
>---
>diff -puN backup/v1.2.5/makedumpfile.c makedumpfile/makedumpfile.c
>--- backup/v1.2.5/makedumpfile.c 2008-03-28 11:54:48.000000000 +0900
>+++ makedumpfile/makedumpfile.c 2008-04-01 14:32:03.000000000 +0900
>@@ -5855,7 +5855,7 @@ handle_xen()
> MSG("\n");
> MSG("The dumpfile is saved to %s.\n", info->name_dumpfile);
>
>- return COMPLETED;
>+ return TRUE;
> out:
> return FALSE;
> #endif
>@@ -6146,7 +6146,8 @@ main(int argc, char *argv[])
> goto out;
> }
> info->dump_level |= DL_EXCLUDE_XEN;
>- return handle_xen();
>+ if (!handle_xen())
>+ goto out;
>
> } else if (info->flag_rearrange) {
> if (!open_files_for_rearranging_dumpdata())
